IGNITE-10837 Add ips of baseline nodes to control.sh --baseline by kgusakov · Pull Request #8351 · apache/ignite

kgusakov · 2020-10-12T14:10:23Z

Enriched the output of control.sh --baseline command with IPs of baseline and coordinator nodes.

Before:

Time: 2020-10-12T16:52:15.539
Command [BASELINE] started
Arguments: --verbose --baseline --yes
--------------------------------------------------------------------------------
Cluster state: active
Current topology version: 1
Baseline auto adjustment disabled: softTimeout=300000

Current topology version: 1 (Coordinator: ConsistentId=gridCommandHandlerTest0, Order=1)

Baseline nodes:
    ConsistentId=gridCommandHandlerTest0, State=ONLINE, Order=1
--------------------------------------------------------------------------------
Number of baseline nodes: 1

Other nodes not found.
Command [BASELINE] finished with code: 0
Control utility has completed execution at: 2020-10-12T16:52:15.614
Execution time: 75 ms

After 1 (non-verbose mode)

Time: 2020-10-12T16:52:15.539
Command [BASELINE] started
Arguments: --baseline --yes
--------------------------------------------------------------------------------
Cluster state: active
Current topology version: 1
Baseline auto adjustment disabled: softTimeout=300000

Current topology version: 1 (Coordinator: ConsistentId=gridCommandHandlerTest0, Address=188.166.164.247.hostname/188.166.164.247, Order=1)

Baseline nodes:
    ConsistentId=gridCommandHandlerTest0, Address=188.166.164.247.hostname/188.166.164.247, State=ONLINE, Order=1
--------------------------------------------------------------------------------
Number of baseline nodes: 1

Other nodes not found.
Command [BASELINE] finished with code: 0
Control utility has completed execution at: 2020-10-12T16:52:15.614
Execution time: 75 ms

After 2 (--verbose)

Time: 2020-10-12T16:52:15.539
Command [BASELINE] started
Arguments: --verbose --baseline --yes
--------------------------------------------------------------------------------
Cluster state: active
Current topology version: 1
Baseline auto adjustment disabled: softTimeout=300000

Current topology version: 1 (Coordinator: ConsistentId=gridCommandHandlerTest0, Addresses=188.166.164.247.hostname/188.166.164.247,10.19.112.175.hostname/10.19.112.175, Order=1)

Baseline nodes:
    ConsistentId=gridCommandHandlerTest0, Addresses=188.166.164.247.hostname/188.166.164.247,10.19.112.175.hostname/10.19.112.175, State=ONLINE, Order=1
--------------------------------------------------------------------------------
Number of baseline nodes: 1

Other nodes not found.
Command [BASELINE] finished with code: 0
Control utility has completed execution at: 2020-10-12T16:52:15.614
Execution time: 75 ms

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

There is a single JIRA ticket related to the pull request.
The web-link to the pull request is attached to the JIRA ticket.
The JIRA ticket has the Patch Available state.
The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

...es/control-utility/src/main/java/org/apache/ignite/internal/commandline/BaselineCommand.java

modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerTest.java

modules/core/src/main/java/org/apache/ignite/IgniteSystemProperties.java

modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java

...es/core/src/main/java/org/apache/ignite/internal/visor/baseline/VisorBaselineTaskResult.java

kgusakov · 2020-10-16T08:04:57Z

@sanpwc comments resolved

...es/control-utility/src/main/java/org/apache/ignite/internal/commandline/AbstractCommand.java

...e/src/test/resources/org.apache.ignite.util/GridCommandHandlerClusterByClassTest_help.output

...es/control-utility/src/main/java/org/apache/ignite/internal/commandline/BaselineCommand.java

modules/core/src/main/java/org/apache/ignite/internal/visor/baseline/VisorBaselineNode.java

...es/core/src/main/java/org/apache/ignite/internal/visor/baseline/VisorBaselineTaskResult.java

…h IPs of baseline and coordinator nodes. Fixes apache#8351 Signed-off-by: Slava Koptilin <slava.koptilin@gmail.com> (cherry picked from commit 0baa6b7)

…mand with IPs of baseline and coordinator nodes. Fixes apache#8351" This reverts commit fb034bd

kgusakov added 3 commits October 12, 2020 16:59

IGNITE-10837 Add ips of baseline nodes to control.sh --baseline

b994b65

Fix checkstyle

70b535c

Add @SystemProperty annotation

12eff9f